Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2974223002: Support is tests (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Including function types #

Patch Set 3 : + as cast #

Patch Set 4 : Cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -56 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 5 chunks +12 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +12 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 8 chunks +36 lines, -27 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 2 3 chunks +13 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-07-11 14:15:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm + sra FYI: this seems to be close to what you were hacking on ...
3 years, 5 months ago (2017-07-11 21:13:16 UTC) #4
sra1
https://codereview.chromium.org/2974223002/diff/60001/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/2974223002/diff/60001/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode75 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:75: class Generic<T> {} This could be a separate test.
3 years, 5 months ago (2017-07-11 21:46:25 UTC) #5
Johnni Winther
https://codereview.chromium.org/2974223002/diff/60001/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/2974223002/diff/60001/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode75 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:75: class Generic<T> {} On 2017/07/11 21:46:25, sra1 wrote: > ...
3 years, 5 months ago (2017-07-12 07:51:30 UTC) #6
Johnni Winther
3 years, 5 months ago (2017-07-12 07:59:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
cca9a1573b88c5d2a078d746741398bbfa51221e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698