Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10224)

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: created symbolizer.py Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index 7ba90321b634c4d0e2a01987e9334ea12f30db56..430d91dac3cbb37cc37832f6a4ef3d12e275c856 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -533,14 +533,18 @@ class LocalDeviceInstrumentationTestRun(
for result in results:
if result.GetType() == base_test_result.ResultType.CRASH:
if not tombstones_url:
+ symbolizer = self._test_instance.symbolizer
jbudorick 2017/07/20 15:58:03 nit: just use this in the call; no need to assign
BigBossZhiling 2017/07/20 23:11:37 Done.
resolved_tombstones = tombstones.ResolveTombstones(
device,
resolve_all_tombstones=True,
include_stack_symbols=False,
- wipe_tombstones=True)
+ wipe_tombstones=True,
+ tombstone_symbolizer=symbolizer)
stream_name = 'tombstones_%s_%s' % (
time.strftime('%Y%m%dT%H%M%S-UTC', time.gmtime()),
device.serial)
+ with open('/tmp/tmp_tombstones.txt', 'w') as f:
jbudorick 2017/07/20 15:58:03 Leftover from debugging?
BigBossZhiling 2017/07/20 23:11:37 Done.
+ f.write('\n'.join(resolved_tombstones))
tombstones_url = logdog_helper.text(
stream_name, '\n'.join(resolved_tombstones))
result.SetLink('tombstones', tombstones_url)

Powered by Google App Engine
This is Rietveld 408576698