build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 2974163002: Fix the stack script issue when symbolizing tombstones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)

Patch Set: add tombstones_helper into git Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | build/android/tombstones_helper.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 7ba90321b634c4d0e2a01987e9334ea12f30db56..6b5e2ea8e729c069e181e4434bcd1dd446687809 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -533,7 +533,8 @@ class LocalDeviceInstrumentationTestRun(

for result in results:

if result.GetType() == base_test_result.ResultType.CRASH:

if not tombstones_url:

- resolved_tombstones = tombstones.ResolveTombstones(

+ tombstones_helper = self._test_instance.tombstones_helper

+ resolved_tombstones = tombstones_helper.ResolveTombstones(

device,

resolve_all_tombstones=True,

include_stack_symbols=False,

« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | build/android/tombstones_helper.py » ('J')