Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/mb/mb.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: address Andrew's comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 7335448bd5a15ddcc913a338ae361637743284e6..27229375e3ae4e4efdfbc285818592ebebcf6f30 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -886,6 +886,15 @@ class MetaBuildWrapper(object):
command, extra_files = self.GetIsolateCommand(target, vals)
runtime_deps = self.ReadFile(runtime_deps_path).splitlines()
+ if android:
jbudorick 2017/07/26 18:39:56 I'm concerned about hacking this into mb.py rather
agrieve 2017/07/26 19:03:57 In GN, "runtime_deps" are the things required to r
+ unstripped_libs = []
jbudorick 2017/07/26 21:55:53 one caveat: please add a TODO here with the bug nu
BigBossZhiling 2017/07/26 22:11:54 Done.
+ for f in runtime_deps:
+ if f.endswith('.so'):
+ if os.path.isfile(self.PathJoin(self.ToAbsPath(build_dir),
+ 'lib.unstripped',
+ os.path.basename(f))):
+ unstripped_libs.append('lib.unstripped/%s' % os.path.basename(f))
+ runtime_deps.extend(unstripped_libs)
self.WriteIsolateFiles(build_dir, command, target, runtime_deps,
extra_files)
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698