build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 2974163002: Fix the stack script issue when symbolizing tombstones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)

Patch Set: address andrew's comments, enable intentional crash test case Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/pylib/symbols/stack_symbolizer.py » ('j') | build/android/pylib/symbols/stack_symbolizer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 7ba90321b634c4d0e2a01987e9334ea12f30db56..4ff0c910b3348c9bffbb25bbed62332fc68bd508 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -537,7 +537,8 @@ class LocalDeviceInstrumentationTestRun(

device,

resolve_all_tombstones=True,

include_stack_symbols=False,

- wipe_tombstones=True)

+ wipe_tombstones=True,

+ tombstone_symbolizer=self._test_instance.symbolizer)

stream_name = 'tombstones_%s_%s' % (

time.strftime('%Y%m%dT%H%M%S-UTC', time.gmtime()),

device.serial)