Fix the stack script issue when symbolizing tombstones.

build/android/pylib/instrumentation/instrumentation_test_instance.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import os
 import pickle
 import re
+import shutil
+import tempfile
 
 from devil.android import apk_helper
 from devil.android import md5sum
 from pylib import constants
 from pylib.base import base_test_result
 from pylib.base import test_exception
 from pylib.base import test_instance
 from pylib.constants import host_paths
 from pylib.instrumentation import test_result
 from pylib.instrumentation import instrumentation_parser
 from pylib.utils import dexdump
 from pylib.utils import proguard
 from pylib.utils import shared_preference_utils
+from pylib.utils import symbolizer
+
 
 with host_paths.SysPath(host_paths.BUILD_COMMON_PATH):
   import unittest_util # pylint: disable=import-error
 
 # Ref: http://developer.android.com/reference/android/app/Activity.html
 _ACTIVITY_RESULT_CANCELED = 0
 _ACTIVITY_RESULT_OK = -1
 
 _COMMAND_LINE_PARAMETER = 'cmdlinearg-parameter'
 _DEFAULT_ANNOTATIONS = [
@@ skipping 403 matching lines @@
 
     self._render_results_dir = None
     self._screenshot_dir = None
     self._timeout_scale = None
     self._initializeTestControlAttributes(args)
 
     self._coverage_directory = None
     self._initializeTestCoverageAttributes(args)
 
     self._store_tombstones = False
+    self._unzipped_files_dir = None
+    self._symbolizer = symbolizer.Symbolizer()
     self._initializeTombstonesAttributes(args)
 
     self._gs_results_bucket = None
     self._should_save_logcat = None
     self._initializeLogAttributes(args)
 
     self._edit_shared_prefs = []
     self._initializeEditPrefsAttributes(args)
 
     self._replace_system_package = None
@@ skipping 161 matching lines @@
     self._render_results_dir = args.render_results_dir
     self._screenshot_dir = args.screenshot_dir
     self._timeout_scale = args.timeout_scale or 1
     self._ui_screenshot_dir = args.ui_screenshot_dir
 
   def _initializeTestCoverageAttributes(self, args):
     self._coverage_directory = args.coverage_dir
 
   def _initializeTombstonesAttributes(self, args):
     self._store_tombstones = args.store_tombstones
+    self._unzipped_files_dir = tempfile.mkdtemp()

[jbudorick, 2017/07/20 15:58:03]

Hmm. Why should the test instance (or the client generally) be responsible for
the symbolizer's unzipped files directory?

[BigBossZhiling, 2017/07/20 23:11:37]

Done.

+    self._symbolizer = symbolizer.Symbolizer(
+        self.apk_under_test.path if self.apk_under_test else None,
+        args.enable_relocation_packing,
+        self._unzipped_files_dir)
 
   def _initializeLogAttributes(self, args):
     self._gs_results_bucket = args.gs_results_bucket
     self._should_save_logcat = bool(args.json_results_file)
 
   def _initializeEditPrefsAttributes(self, args):
     if not hasattr(args, 'shared_prefs_file') or not args.shared_prefs_file:
       return
     if not isinstance(args.shared_prefs_file, str):
       logging.warning("Given non-string for a filepath")
@@ skipping 73 matching lines @@
 
   @property
   def store_tombstones(self):
     return self._store_tombstones
 
   @property
   def suite(self):
     return self._suite
 
   @property
+  def symbolizer(self):
+    return self._symbolizer
+
+  @property
   def test_apk(self):
     return self._test_apk
 
   @property
   def test_apk_incremental_install_script(self):
     return self._test_apk_incremental_install_script
 
   @property
   def test_jar(self):
     return self._test_jar
@@ skipping 109 matching lines @@
     return ParseAmInstrumentRawOutput(raw_output)
 
   @staticmethod
   def GenerateTestResults(
       result_code, result_bundle, statuses, start_ms, duration_ms):
     return GenerateTestResults(result_code, result_bundle, statuses,
                                start_ms, duration_ms)
 
   #override
   def TearDown(self):
-    pass
+    if self._unzipped_files_dir:
+      shutil.rmtree(self._unzipped_files_dir)