Fix the stack script issue when symbolizing tombstones.

build/android/tombstones_helper.py

+#!/usr/bin/env python

[jbudorick, 2017/07/18 14:11:47]

This shouldn't be executable and shouldn't start with the shebang line.

[BigBossZhiling, 2017/07/18 22:16:08]

Done.

+#

[jbudorick, 2017/07/18 14:11:47]

This file should be in pylib/ somewhere -- probably in pylib/utils/. Very little
should be added directly to //build/android at this point.

[BigBossZhiling, 2017/07/18 22:16:09]

Done.

+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os
+import subprocess
+import tombstones
+
+class TombstonesHelper(object):

[jbudorick, 2017/07/18 14:11:46]

I probably wasn't clear enough with my intended design here. The new object
should be responsible for symbolization generally, not just for tombstones. (I
think we'd like to use it to symbolize stacks in other contexts.) As such, it
shouldn't be a wrapper around tombstones. This may require reworking tombstones
itself a bit.

Let's talk about this a bit more when you get in.

[BigBossZhiling, 2017/07/18 22:16:09]

Done.

+  """ A helper class to coordinate between tombstones.py and stack script. """
+
+  def __init__(self, apk_under_test=None,
+               enable_relocation_packing=None, libs_dir=None):
+    self.apk_under_test = apk_under_test
+    self.enable_relocation_packing = enable_relocation_packing
+    self.libs_dir = libs_dir
+    self.packed_libs = []
+
+  def UnzipAPK(self):
+    subprocess.check_call(
+        ['unzip', '-o', self.apk_under_test, '-d', self.libs_dir])
+    if os.path.exists(os.path.join(self.libs_dir, 'lib')):
+      for root, _, files in os.walk(os.path.join(self.libs_dir,
+                                                 'lib')):
+        for file_name in files:
+          if file_name.endswith('.so'):
+            self.packed_libs.append(os.path.join(root, file_name))
+
+  def ResolveTombstones(self, device, resolve_all_tombstones=True,
+                        include_stack_symbols=False,
+                        wipe_tombstones=True):
+    if self.enable_relocation_packing and self.apk_under_test:
+      self.UnzipAPK()
+    return tombstones.ResolveTombstones(
+      device, resolve_all_tombstones=resolve_all_tombstones,
+      include_stack_symbols=include_stack_symbols,
+      wipe_tombstones=wipe_tombstones, packed_libs=self.packed_libs)