Document dart2js flags in dartjs -h

Document dart2js flags in dartjs -h

R=kathyw@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/d60fe4de18ad66cde11d5bcc31f520b1262d7ea5

[Siggi Cherem (dart-lang), 2017-07-10 19:48:00]

Description was changed from

==========
Document dart2js flags
==========

to

==========
Document dart2js flags in dartjs -h
==========

[Siggi Cherem (dart-lang), 2017-07-10 19:49:11]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com, kathyw@google.com

[Siggi Cherem (dart-lang), 2017-07-10 19:50:31]

sigmund@google.com changed reviewers:
+ sra@google.com

[Siggi Cherem (dart-lang), 2017-07-10 19:51:07]

BTW - I took most of the text Kathy wrote on the site
(https://webdev.dartlang.org/tools/dart2js) and adjusted it slightly.

[sra1, 2017-07-10 19:52:05]

lgtm

[Kathy Walrath, 2017-07-10 19:55:07]

A couple of suggestions, but LGTM.

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:741: Disables dynamic generation of code in
the generated output. This is
While you're in here...

Disables -> Disable

(to match the format of the other help items)

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:769: Use this option only if you have enough
testing to ensure that those checks
Delete this paragraph? If not, then delete the second sentence of the intro
paragraph above ("Only turn on these flags if...").

[Siggi Cherem (dart-lang), 2017-07-10 19:57:55]

thanks!

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:741: Disables dynamic generation of code in
the generated output. This is
On 2017/07/10 19:55:06, Kathy Walrath wrote:
> While you're in here...
> 
> Disables -> Disable
> 
> (to match the format of the other help items)

Done.

https://codereview.chromium.org/2974133002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:769: Use this option only if you have enough
testing to ensure that those checks
On 2017/07/10 19:55:06, Kathy Walrath wrote:
> Delete this paragraph? If not, then delete the second sentence of the intro
> paragraph above ("Only turn on these flags if...").

Done.

[Siggi Cherem (dart-lang), 2017-07-10 19:58:19]

Description was changed from

==========
Document dart2js flags in dartjs -h
==========

to

==========
Document dart2js flags in dartjs -h

R=kathyw@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d60fe4de18ad66cde11d5bcc31f520b1262d7ea5
==========

[Siggi Cherem (dart-lang), 2017-07-10 19:58:21]

Committed patchset #2 (id:20001) manually as
d60fe4de18ad66cde11d5bcc31f520b1262d7ea5 (presubmit successful).