Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2974033002: Revert of Reenable disabled component extensions with profile resetter.

Created:
3 years, 5 months ago by mtomasz
Modified:
3 years, 5 months ago
Reviewers:
lazyboy, battre
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable disabled component extensions with profile resetter. (patchset #6 id:100001 of https://codereview.chromium.org/2647783003/ ) Reason for revert: It didn't work as expected, so removing dead code. Original issue's description: > Reenable disabled component extensions with profile resetter. > > Sice disabled extensions are synced and component extensions do not > have a UI for reenabling them, once disabled will stay disabled forever. > > It happened that for some reason some component extensions were > disabled. The reason is unknown, but at least users will be able to > recover from this situation by using the profile resetter. > > Note, that we allow to disable component extensions programatically, > which was used at least for the Hotword component extension. > > TEST=Disable a component extension programatically, then reset the > profile in chrome://settings. > BUG=680429 > > Review-Url: https://codereview.chromium.org/2647783003 > Cr-Commit-Position: refs/heads/master@{#446575} > Committed: https://chromium.googlesource.com/chromium/src/+/622f70d2786a5dd446c45fa8222ce2d14d98cbf5 TBR=battre@chromium.org,lazyboy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtomasz
Created Revert of Reenable disabled component extensions with profile resetter.
3 years, 5 months ago (2017-07-10 08:54:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2974033002/1
3 years, 5 months ago (2017-07-10 08:54:41 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 08:57:12 UTC) #5
Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698