Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 2974013002: remove unused analysis server flag (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 import 'dart:math'; 7 import 'dart:math';
8 8
9 import 'package:analysis_server/src/analysis_server.dart'; 9 import 'package:analysis_server/src/analysis_server.dart';
10 import 'package:analysis_server/src/plugin/server_plugin.dart'; 10 import 'package:analysis_server/src/plugin/server_plugin.dart';
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 * console instead of being intercepted. 228 * console instead of being intercepted.
229 */ 229 */
230 static const String INTERNAL_PRINT_TO_CONSOLE = "internal-print-to-console"; 230 static const String INTERNAL_PRINT_TO_CONSOLE = "internal-print-to-console";
231 231
232 /** 232 /**
233 * The name of the option used to describe the new analysis driver logger. 233 * The name of the option used to describe the new analysis driver logger.
234 */ 234 */
235 static const String NEW_ANALYSIS_DRIVER_LOG = 'new-analysis-driver-log'; 235 static const String NEW_ANALYSIS_DRIVER_LOG = 'new-analysis-driver-log';
236 236
237 /** 237 /**
238 * The name of the option used to enable verbose Flutter completion code gener ation.
239 */
240 static const String VERBOSE_FLUTTER_COMPLETIONS =
241 'verbose-flutter-completions';
242
243 /**
244 * The name of the flag used to enable version 2 of semantic highlight 238 * The name of the flag used to enable version 2 of semantic highlight
245 * notification. 239 * notification.
246 */ 240 */
247 static const String USE_ANALYSIS_HIGHLIGHT2 = "useAnalysisHighlight2"; 241 static const String USE_ANALYSIS_HIGHLIGHT2 = "useAnalysisHighlight2";
248 242
249 /** 243 /**
250 * The option for specifying the http diagnostic port. 244 * The option for specifying the http diagnostic port.
251 * If specified, users can review server status and performance information 245 * If specified, users can review server status and performance information
252 * by opening a web browser on http://localhost:<port> 246 * by opening a web browser on http://localhost:<port>
253 */ 247 */
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 ArgResults results = parser.parse(arguments, <String, String>{}); 301 ArgResults results = parser.parse(arguments, <String, String>{});
308 302
309 AnalysisServerOptions analysisServerOptions = new AnalysisServerOptions(); 303 AnalysisServerOptions analysisServerOptions = new AnalysisServerOptions();
310 analysisServerOptions.useAnalysisHighlight2 = 304 analysisServerOptions.useAnalysisHighlight2 =
311 results[USE_ANALYSIS_HIGHLIGHT2]; 305 results[USE_ANALYSIS_HIGHLIGHT2];
312 analysisServerOptions.fileReadMode = results[FILE_READ_MODE]; 306 analysisServerOptions.fileReadMode = results[FILE_READ_MODE];
313 analysisServerOptions.newAnalysisDriverLog = 307 analysisServerOptions.newAnalysisDriverLog =
314 results[NEW_ANALYSIS_DRIVER_LOG]; 308 results[NEW_ANALYSIS_DRIVER_LOG];
315 analysisServerOptions.clientId = results[CLIENT_ID]; 309 analysisServerOptions.clientId = results[CLIENT_ID];
316 analysisServerOptions.clientVersion = results[CLIENT_VERSION]; 310 analysisServerOptions.clientVersion = results[CLIENT_VERSION];
317 analysisServerOptions.enableVerboseFlutterCompletions =
318 results[VERBOSE_FLUTTER_COMPLETIONS];
319 311
320 ContextBuilderOptions.flutterRepo = results[FLUTTER_REPO]; 312 ContextBuilderOptions.flutterRepo = results[FLUTTER_REPO];
321 313
322 telemetry.Analytics analytics = telemetry.createAnalyticsInstance( 314 telemetry.Analytics analytics = telemetry.createAnalyticsInstance(
323 'UA-26406144-29', 'analysis-server', 315 'UA-26406144-29', 'analysis-server',
324 disableForSession: results[SUPPRESS_ANALYTICS_FLAG]); 316 disableForSession: results[SUPPRESS_ANALYTICS_FLAG]);
325 analysisServerOptions.analytics = analytics; 317 analysisServerOptions.analytics = analytics;
326 318
327 if (analysisServerOptions.clientId != null) { 319 if (analysisServerOptions.clientId != null) {
328 // Record the client name as the application installer ID. 320 // Record the client name as the application installer ID.
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 defaultsTo: false, 496 defaultsTo: false,
505 negatable: false); 497 negatable: false);
506 parser.addOption(INSTRUMENTATION_LOG_FILE, 498 parser.addOption(INSTRUMENTATION_LOG_FILE,
507 help: "write instrumentation data to the given file"); 499 help: "write instrumentation data to the given file");
508 parser.addFlag(INTERNAL_PRINT_TO_CONSOLE, 500 parser.addFlag(INTERNAL_PRINT_TO_CONSOLE,
509 help: "enable sending `print` output to the console", 501 help: "enable sending `print` output to the console",
510 defaultsTo: false, 502 defaultsTo: false,
511 negatable: false); 503 negatable: false);
512 parser.addOption(NEW_ANALYSIS_DRIVER_LOG, 504 parser.addOption(NEW_ANALYSIS_DRIVER_LOG,
513 help: "set a destination for the new analysis driver's log"); 505 help: "set a destination for the new analysis driver's log");
514 parser.addFlag(VERBOSE_FLUTTER_COMPLETIONS,
515 help: "enable verbose code completion for Flutter (experimental)");
516 parser.addFlag(ANALYTICS_FLAG, 506 parser.addFlag(ANALYTICS_FLAG,
517 help: 'enable or disable sending analytics information to Google'); 507 help: 'enable or disable sending analytics information to Google');
518 parser.addFlag(SUPPRESS_ANALYTICS_FLAG, 508 parser.addFlag(SUPPRESS_ANALYTICS_FLAG,
519 negatable: false, help: 'suppress analytics for this session'); 509 negatable: false, help: 'suppress analytics for this session');
520 parser.addOption(PORT_OPTION, 510 parser.addOption(PORT_OPTION,
521 help: "the http diagnostic port on which the server provides" 511 help: "the http diagnostic port on which the server provides"
522 " status and performance information"); 512 " status and performance information");
523 parser.addOption(SDK_OPTION, help: "[path] the path to the sdk"); 513 parser.addOption(SDK_OPTION, help: "[path] the path to the sdk");
524 parser.addFlag(USE_ANALYSIS_HIGHLIGHT2, 514 parser.addFlag(USE_ANALYSIS_HIGHLIGHT2,
525 help: "enable version 2 of semantic highlight", 515 help: "enable version 2 of semantic highlight",
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 616
627 _DiagnosticServerImpl(); 617 _DiagnosticServerImpl();
628 618
629 @override 619 @override
630 Future<int> getServerPort() => httpServer.serveHttp(); 620 Future<int> getServerPort() => httpServer.serveHttp();
631 621
632 Future startOnPort(int port) { 622 Future startOnPort(int port) {
633 return httpServer.serveHttp(port); 623 return httpServer.serveHttp(port);
634 } 624 }
635 } 625 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698