Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2973973002: Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1 (Closed)
Patch Set: Fix handling of aria-haspopup=false Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
index 6ec4a83678c7dabecb04bfa9a855b0987899e4b3..fa0c1f71a03feef8fcd62f1e79ca1e0ad508e6b1 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
@@ -165,8 +165,8 @@ void FillWidgetProperties(AXObject& ax_object,
CreateProperty(AXWidgetAttributesEnum::Autocomplete,
CreateValue(autocomplete, AXValueTypeEnum::Token)));
- if (ax_object.HasAttribute(HTMLNames::aria_haspopupAttr)) {
- bool has_popup = ax_object.AriaHasPopup();
+ bool has_popup = ax_object.AriaHasPopup();
+ if (has_popup || ax_object.HasAttribute(HTMLNames::aria_haspopupAttr)) {
properties.addItem(CreateProperty(AXWidgetAttributesEnum::Haspopup,
CreateBooleanValue(has_popup)));
}
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698