Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2973963003: Release mouse pointer capture when it starts drag (Closed)
Patch Set: Remove is_cancel from parameters Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 .IsNone() && 557 .IsNone() &&
558 !capturing_mouse_events_node_) { 558 !capturing_mouse_events_node_) {
559 return i_beam; 559 return i_beam;
560 } 560 }
561 561
562 if (ShouldShowIBeamForNode(node, result)) 562 if (ShouldShowIBeamForNode(node, result))
563 return i_beam; 563 return i_beam;
564 return PointerCursor(); 564 return PointerCursor();
565 } 565 }
566 566
567 WebInputEventResult EventHandler::HandlePointerEvent(
568 const WebPointerEvent& web_pointer_event,
569 Node* target) {
570 return pointer_event_manager_->HandlePointerEvent(web_pointer_event, target);
571 }
572
567 WebInputEventResult EventHandler::HandleMousePressEvent( 573 WebInputEventResult EventHandler::HandleMousePressEvent(
568 const WebMouseEvent& mouse_event) { 574 const WebMouseEvent& mouse_event) {
569 TRACE_EVENT0("blink", "EventHandler::handleMousePressEvent"); 575 TRACE_EVENT0("blink", "EventHandler::handleMousePressEvent");
570 576
571 // For 4th/5th button in the mouse since Chrome does not yet send 577 // For 4th/5th button in the mouse since Chrome does not yet send
572 // button value to Blink but in some cases it does send the event. 578 // button value to Blink but in some cases it does send the event.
573 // This check is needed to suppress such an event (crbug.com/574959) 579 // This check is needed to suppress such an event (crbug.com/574959)
574 if (mouse_event.button == WebPointerProperties::Button::kNoButton) 580 if (mouse_event.button == WebPointerProperties::Button::kNoButton)
575 return WebInputEventResult::kHandledSuppressed; 581 return WebInputEventResult::kHandledSuppressed;
576 582
(...skipping 1519 matching lines...) Expand 10 before | Expand all | Expand 10 after
2096 MouseEventWithHitTestResults& mev, 2102 MouseEventWithHitTestResults& mev,
2097 LocalFrame* subframe) { 2103 LocalFrame* subframe) {
2098 WebInputEventResult result = 2104 WebInputEventResult result =
2099 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event()); 2105 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
2100 if (result != WebInputEventResult::kNotHandled) 2106 if (result != WebInputEventResult::kNotHandled)
2101 return result; 2107 return result;
2102 return WebInputEventResult::kHandledSystem; 2108 return WebInputEventResult::kHandledSystem;
2103 } 2109 }
2104 2110
2105 } // namespace blink 2111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698