update strong mode test for fasta scanner

update strong mode test for fasta scanner

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/db02df3d3fc63772e95e01f92d51df9c188fd635

[danrubel, 2017-07-07 13:42:40]

danrubel@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-07-07 13:54:19]

lgtm

https://codereview.chromium.org/2973963002/diff/1/tests/language_strong/numbe...
File tests/language_strong/number_identifier_test.dart (right):

https://codereview.chromium.org/2973963002/diff/1/tests/language_strong/numbe...
tests/language_strong/number_identifier_test.dart:32: Expect.throws(() => 1.e+2,
//                      //# 05: static type warning
I think this might be a "compile-time error" (e.g., line 34) now in strong mode.

And, Jen's suppression should probably stay, right?

https://github.com/dart-lang/sdk/commit/79cace0848c57479dca0caa202b71f86e9746...

[danrubel, 2017-07-07 16:27:29]

On 2017/07/07 13:54:19, vsm wrote:
>
https://codereview.chromium.org/2973963002/diff/1/tests/language_strong/numbe...
> tests/language_strong/number_identifier_test.dart:32: Expect.throws(() =>
1.e+2,
> //                      //# 05: static type warning
> I think this might be a "compile-time error" (e.g., line 34) now in strong
mode.

That's what I needed. Updated and re-enabled the test. Thanks!

[danrubel, 2017-07-07 16:27:55]

Description was changed from

==========
update strong mode test for fasta scanner
==========

to

==========
update strong mode test for fasta scanner

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/db02df3d3fc63772e95e01f92d51df9c188fd635
==========

[danrubel, 2017-07-07 16:27:57]

Committed patchset #2 (id:20001) manually as
db02df3d3fc63772e95e01f92d51df9c188fd635 (presubmit successful).