Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2973933002: Changed expect.dart typeAssertionsEnabled to pass strong mode tests. (Closed)

Created:
3 years, 5 months ago by eernst
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Changed expect.dart typeAssertionsEnabled to pass strong mode tests. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5c213ab9298b87770b500ef74e58288a0a254e18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/expect/lib/expect.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
The --enable-asserts CL included `var i = 42; String s = i;` which does the ...
3 years, 5 months ago (2017-07-07 12:13:25 UTC) #2
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-07 12:14:38 UTC) #3
eernst
3 years, 5 months ago (2017-07-07 12:24:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c213ab9298b87770b500ef74e58288a0a254e18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698