extensions/renderer/resources/guest_view/web_view/web_view_events.js - Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_events.js

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/context_menus_handlers.js ('K') | « extensions/renderer/resources/guest_view/guest_view_events.js ('k') | extensions/renderer/resources/messaging.js » ('j') | extensions/renderer/resources/messaging.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/web_view/web_view_events.js

diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_events.js b/extensions/renderer/resources/guest_view/web_view/web_view_events.js

index c52684d7a444f87278f17b2af797595c9f96c7a1..67916152158d57311e1076d5844577907d6b6d29 100644

--- a/extensions/renderer/resources/guest_view/web_view/web_view_events.js

+++ b/extensions/renderer/resources/guest_view/web_view/web_view_events.js

@@ -38,7 +38,7 @@ function createCustomDeclarativeEvent(name, schema, options, webviewId) {

function createCustomEvent(name, schema, options) {

if (bindingUtil)

- return bindingUtil.createCustomEvent(name, undefined, false);

+ return bindingUtil.createCustomEvent(name, undefined, false, false);

if (!jsEvent)

jsEvent = require('event_bindings').Event;

return new jsEvent(name, schema, options);

lazyboy 2017/07/14 00:04:42 Can we DCHECK options.supportsLazyEvents == false?

Devlin 2017/07/14 15:37:54 Good idea; done.