Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: extensions/renderer/bindings/api_event_handler.h

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/bindings/api_event_handler.h
diff --git a/extensions/renderer/bindings/api_event_handler.h b/extensions/renderer/bindings/api_event_handler.h
index bca7319ba7d3e201e45c1cc32bc67debfe17e5d9..36c3fb4e730e9332f75837911de84d321d617b17 100644
--- a/extensions/renderer/bindings/api_event_handler.h
+++ b/extensions/renderer/bindings/api_event_handler.h
@@ -35,7 +35,7 @@ class APIEventHandler {
base::Callback<void(const std::string& event_name,
binding::EventListenersChanged,
const base::DictionaryValue* filter,
- bool was_manual,
+ bool update_lazy_listeners,
v8::Local<v8::Context>)>;
APIEventHandler(const binding::RunJSFunction& call_js,
@@ -45,8 +45,11 @@ class APIEventHandler {
// Returns a new v8::Object for an event with the given |event_name|. If
// |notify_on_change| is true, notifies whenever listeners state is changed.
+ // TODO(devlin): Maybe worth creating a Params struct to hold the event
+ // information?
v8::Local<v8::Object> CreateEventInstance(const std::string& event_name,
bool supports_filters,
+ bool supports_lazy_listeners,
int max_listeners,
bool notify_on_change,
v8::Local<v8::Context> context);

Powered by Google App Engine
This is Rietveld 408576698