Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_events.js

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: onMessage event fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view/web_view_events.js
diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_events.js b/extensions/renderer/resources/guest_view/web_view/web_view_events.js
index c52684d7a444f87278f17b2af797595c9f96c7a1..25fd14a273e4ea8e6126e5a9b39b5e12226c6d49 100644
--- a/extensions/renderer/resources/guest_view/web_view/web_view_events.js
+++ b/extensions/renderer/resources/guest_view/web_view/web_view_events.js
@@ -5,6 +5,7 @@
// Event management for WebView.
var CreateEvent = require('guestViewEvents').CreateEvent;
+var DCHECK = requireNative('logging').DCHECK;
var DeclarativeWebRequestSchema =
requireNative('schema_registry').GetSchema('declarativeWebRequest');
var GuestViewEvents = require('guestViewEvents').GuestViewEvents;
@@ -37,10 +38,17 @@ function createCustomDeclarativeEvent(name, schema, options, webviewId) {
}
function createCustomEvent(name, schema, options) {
- if (bindingUtil)
- return bindingUtil.createCustomEvent(name, undefined, false);
+ var supportsLazyListeners = false;
+ if (bindingUtil) {
+ return bindingUtil.createCustomEvent(name, undefined, false,
+ supportsLazyListeners);
+ }
if (!jsEvent)
jsEvent = require('event_bindings').Event;
+
+ if (!options)
+ options = {__proto__: null, supportsLazyListeners: false};
+ DCHECK(!options.supportsLazyListeners);
return new jsEvent(name, schema, options);
}
« no previous file with comments | « extensions/renderer/resources/guest_view/guest_view_events.js ('k') | extensions/renderer/resources/messaging.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698