Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Unified Diff: extensions/renderer/resources/context_menus_handlers.js

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: onMessage event fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/app_window_custom_bindings.js ('k') | extensions/renderer/resources/event.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/context_menus_handlers.js
diff --git a/extensions/renderer/resources/context_menus_handlers.js b/extensions/renderer/resources/context_menus_handlers.js
index 0e718c4f5acbc8d1873ed85f1b2a495dc932c798..bbbd43fd6ac8f50ed63760af6b187a9f46b0bd66 100644
--- a/extensions/renderer/resources/context_menus_handlers.js
+++ b/extensions/renderer/resources/context_menus_handlers.js
@@ -15,14 +15,22 @@ var hasLastError = bindingUtil ?
require('lastError').hasError;
var jsEvent;
-function createNewEvent(name) {
+function createNewEvent(name, isWebview) {
+ var supportsLazyListeners = !isWebview;
+ var supportsFilters = false;
if (bindingUtil) {
// Native custom events ignore schema.
- return bindingUtil.createCustomEvent(name, undefined, undefined);
+ return bindingUtil.createCustomEvent(name, undefined, supportsFilters,
+ supportsLazyListeners);
}
if (!jsEvent)
jsEvent = require('event_bindings').Event;
- return new jsEvent(name);
+ var eventOpts = {
+ __proto__: null,
+ supportsLazyListeners: supportsLazyListeners,
+ supportsFilters: supportsFilters,
+ };
+ return new jsEvent(name, null, eventOpts);
}
// Add the bindings to the contextMenus API.
@@ -53,7 +61,7 @@ function createContextMenusHandlers(isWebview) {
var contextMenus = { __proto__: null };
contextMenus.handlers = { __proto__: null };
- contextMenus.event = createNewEvent(eventName);
+ contextMenus.event = createNewEvent(eventName, isWebview);
contextMenus.getIdFromCreateProperties = function(createProperties) {
if (typeof createProperties.id !== 'undefined')
« no previous file with comments | « extensions/renderer/resources/app_window_custom_bindings.js ('k') | extensions/renderer/resources/event.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698