Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/renderer/event_bindings.h

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: onMessage event fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/chrome_setting.cc ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/event_bindings.h
diff --git a/extensions/renderer/event_bindings.h b/extensions/renderer/event_bindings.h
index f58b00663d05dd8bf9786b5d636d183192a14b8c..8172f76517b7fdc6443606384608d3bb1fb24a7a 100644
--- a/extensions/renderer/event_bindings.h
+++ b/extensions/renderer/event_bindings.h
@@ -46,7 +46,7 @@ class EventBindings : public ObjectBackedNativeHandler {
// Attach an event name to an object.
// |event_name| The name of the event to attach.
- void AttachEvent(const std::string& event_name);
+ void AttachEvent(const std::string& event_name, bool supports_lazy_listeners);
// JavaScript handler which forwards to DetachEvent().
// args[0] forwards to |event_name|.
@@ -58,7 +58,7 @@ class EventBindings : public ObjectBackedNativeHandler {
// |is_manual| True if this detach was done by the user via removeListener()
// as opposed to automatically during shutdown, in which case we should inform
// the browser we are no longer interested in that event.
- void DetachEvent(const std::string& event_name, bool is_manual);
+ void DetachEvent(const std::string& event_name, bool remove_lazy_listener);
// MatcherID AttachFilteredEvent(string event_name, object filter)
// |event_name| Name of the event to attach.
@@ -79,7 +79,7 @@ class EventBindings : public ObjectBackedNativeHandler {
// |matcher_id| The ID of the filtered event.
// |is_manual| false if this is part of the extension unload process where all
// listeners are automatically detached.
- void DetachFilteredEvent(int matcher_id, bool is_manual);
+ void DetachFilteredEvent(int matcher_id, bool remove_lazy_listener);
void AttachUnmanagedEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
void DetachUnmanagedEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
« no previous file with comments | « extensions/renderer/chrome_setting.cc ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698