Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: extensions/renderer/bindings/api_binding_js_util.cc

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: onMessage event fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/bindings/api_binding_js_util.cc
diff --git a/extensions/renderer/bindings/api_binding_js_util.cc b/extensions/renderer/bindings/api_binding_js_util.cc
index 22e5a237dc9c189c63e7aa133f6f19e227a5ed11..f48637bf986d294ade3ed46784fe16ce4f83cf6f 100644
--- a/extensions/renderer/bindings/api_binding_js_util.cc
+++ b/extensions/renderer/bindings/api_binding_js_util.cc
@@ -117,7 +117,8 @@ void APIBindingJSUtil::RegisterEventArgumentMassager(
void APIBindingJSUtil::CreateCustomEvent(gin::Arguments* arguments,
v8::Local<v8::Value> v8_event_name,
v8::Local<v8::Value> unused_schema,
- bool supports_filters) {
+ bool supports_filters,
+ bool supports_lazy_listeners) {
v8::Isolate* isolate = arguments->isolate();
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = arguments->GetHolderCreationContext();
@@ -133,15 +134,17 @@ void APIBindingJSUtil::CreateCustomEvent(gin::Arguments* arguments,
DCHECK(!supports_filters || !event_name.empty())
<< "Events that support filters cannot be anonymous.";
+ DCHECK(!supports_lazy_listeners || !event_name.empty())
+ << "Events that support lazy listeners cannot be anonymous.";
v8::Local<v8::Value> event;
if (event_name.empty()) {
event = event_handler_->CreateAnonymousEventInstance(context);
} else {
bool notify_on_change = true;
- event = event_handler_->CreateEventInstance(event_name, supports_filters,
- binding::kNoListenerMax,
- notify_on_change, context);
+ event = event_handler_->CreateEventInstance(
+ event_name, supports_filters, supports_lazy_listeners,
+ binding::kNoListenerMax, notify_on_change, context);
}
arguments->Return(event);
« no previous file with comments | « extensions/renderer/bindings/api_binding_js_util.h ('k') | extensions/renderer/bindings/api_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698