Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/renderer/resources/extensions/web_view/chrome_web_view.js

Issue 2973903002: [Extensions Bindings] Introduce a supportsLazyListeners property (Closed)
Patch Set: onMessage event fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view/chrome_web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view/chrome_web_view.js b/chrome/renderer/resources/extensions/web_view/chrome_web_view.js
index 506acffb2b1f4a43f985094c4d9345dc62f366e1..de416fa176861421f005193724a10e5f7c1522a8 100644
--- a/chrome/renderer/resources/extensions/web_view/chrome_web_view.js
+++ b/chrome/renderer/resources/extensions/web_view/chrome_web_view.js
@@ -32,7 +32,7 @@ var ContextMenusHandlerEvent =
var jsEvent;
function createCustomEvent(name, schema, options, webviewId) {
if (bindingUtil)
- return bindingUtil.createCustomEvent(name, undefined, false);
+ return bindingUtil.createCustomEvent(name, undefined, false, false);
if (!jsEvent)
jsEvent = require('event_bindings').Event;
return new jsEvent(name, schema, options, webviewId);
@@ -146,7 +146,7 @@ WebViewImpl.prototype.maybeSetupContextMenus = function() {
var eventName = 'chromeWebViewInternal.onContextMenuShow';
var eventSchema =
utils.lookup(ChromeWebViewSchema.events, 'name', 'onShow');
- var eventOptions = {supportsListeners: true};
+ var eventOptions = {supportsListeners: true, supportsLazyListeners: false};
this.contextMenusOnContextMenuEvent_ = createContextMenusOnContextMenuEvent(
this.viewInstanceId, eventName, eventSchema, eventOptions);
}
@@ -166,7 +166,8 @@ WebViewImpl.prototype.maybeSetupContextMenus = function() {
var eventName = 'chromeWebViewInternal.onClicked';
var eventSchema =
utils.lookup(ChromeWebViewSchema.events, 'name', 'onClicked');
- var eventOptions = {supportsListeners: true};
+ var eventOptions =
+ {supportsListeners: true, supportsLazyListeners: false};
var onClickedEvent = createContextMenusOnClickedEvent(
this.viewInstanceId, eventName, eventSchema, eventOptions);
this.contextMenusOnClickedEvent_ = onClickedEvent;

Powered by Google App Engine
This is Rietveld 408576698