[Extensions Bindings] Introduce a supportsLazyListeners property

chrome/browser/extensions/events_apitest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "chrome/browser/extensions/chrome_extension_test_notification_observer.h"
 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
 #include "chrome/browser/extensions/chrome_test_extension_loader.h"
 #include "chrome/browser/extensions/extension_apitest.h"
@@ skipping 57 matching lines @@
   EXPECT_FALSE(event_router->ExtensionHasEventListener(
       id, "webNavigation.onBeforeNavigate"));
   EXPECT_FALSE(
       event_router->ExtensionHasEventListener(id, "webNavigation.onCommitted"));
   EXPECT_FALSE(event_router->ExtensionHasEventListener(
       id, "webNavigation.onDOMContentLoaded"));
   EXPECT_FALSE(
       event_router->ExtensionHasEventListener(id, "webNavigation.onCompleted"));
 }
 
+// Test that listeners for webview-related events are not stored (even for lazy
+// contexts). See crbug.com/736381.
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebViewEventRegistration) {
+  ASSERT_TRUE(RunPlatformAppTest("events/webview_events")) << message_;
+  EventRouter* event_router = EventRouter::Get(profile());
+  // We should not register lazy listeners for any webview-related events.
+  EXPECT_FALSE(
+      event_router->HasLazyEventListenerForTesting("webViewInternal.onClose"));
+  EXPECT_FALSE(event_router->HasLazyEventListenerForTesting("webview.close"));
+  EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
+      "chromeWebViewInternal.onContextMenuShow"));
+  EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
+      "chromeWebViewInternal.onClicked"));
+  EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
+      "webViewInternal.contextMenus"));
+  // Chrome webview context menu events also use a "subevent" pattern, so we
+  // need to look for suffixed events. These seem to always be suffixed with
+  // "3" and "4", but look for the first 10 to be a bit safer.
+  for (int i = 0; i < 10; ++i) {
+    EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
+        base::StringPrintf("chromeWebViewInternal.onClicked/%d", i)));
+    EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
+        base::StringPrintf("chromeWebViewInternal.onContextMenuShow/%d", i)));
+    EXPECT_FALSE(
+        event_router->HasLazyEventListenerForTesting(base::StringPrintf(
+            "webViewInternal.declarativeWebRequest.onMessage/%d", i)));
+  }
+
+  // Sanity check: app.runtime.onLaunched should have a lazy listener.
+  EXPECT_TRUE(
+      event_router->HasLazyEventListenerForTesting("app.runtime.onLaunched"));
+}
+
 class EventsApiTest : public ExtensionApiTest {
  public:
   EventsApiTest() {}
 
  protected:
   void SetUpOnMainThread() override {
     ExtensionApiTest::SetUpOnMainThread();
     EXPECT_TRUE(scoped_temp_dir_.CreateUniqueTempDir());
   }
 
@@ skipping 218 matching lines @@
   EXPECT_TRUE(observed_extension_names().count("chrome updates listener"));
   EXPECT_FALSE(observed_extension_names().count("chrome updates non listener"));
 
   EXPECT_TRUE(updates_listener()->WaitUntilSatisfied());
   content::RunAllPendingInMessageLoop();
   content::RunAllBlockingPoolTasksUntilIdle();
   EXPECT_FALSE(failure_listener()->was_satisfied());
 }
 
 }  // namespace extensions