Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2973893002: [fuchsia] Use 0 instead of the deprecated MX_PORT_OPT_V2 option (Closed)

Created:
3 years, 5 months ago by kulakowski1
Modified:
3 years, 5 months ago
Reviewers:
zra, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Use 0 instead of the deprecated MX_PORT_OPT_V2 option Magenta has removed ports v1, and subsequently deprecated the need for the MX_PORT_OPT_V2 option. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/9bbfd08910ed4ba527f1176e3ebdeafc88becbbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/bin/eventhandler_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kulakowski1
3 years, 5 months ago (2017-07-06 21:50:42 UTC) #1
zra
lgtm +rmacnak to help land
3 years, 5 months ago (2017-07-07 05:14:10 UTC) #3
rmacnak
3 years, 5 months ago (2017-07-07 17:00:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bbfd08910ed4ba527f1176e3ebdeafc88becbbb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698