Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc

Issue 2973873002: Primary histograms for InBrowserCleanerUI experiment (Closed)
Patch Set: Code reviews Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
index 3c63d8bc4a5df2ca0d4e7b0573455c9d95000774..f22d7204505e52d1bc04e030375e7d30bb96e5b1 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
+++ b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
@@ -15,6 +15,7 @@
#include "base/callback_helpers.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/metrics/histogram_macros.h"
#include "base/sequence_checker.h"
#include "base/synchronization/lock.h"
#include "base/win/registry.h"
@@ -35,6 +36,12 @@ namespace safe_browsing {
namespace {
+enum TaggedProfileForResetting {
csharp 2017/07/07 20:53:33 nit: Add a comment about matching uma
ftirelo 2017/07/07 21:22:08 Done.
+ TAGGED_PROFILE_FOR_RESETTING_TAGGED = 0,
+
+ TAGGED_PROFILE_FOR_RESETTING_MAX,
+};
+
// Returns the post-cleanup reset pending prefs for |profile|.
bool ResetPending(Profile* profile) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -220,6 +227,9 @@ void PostCleanupSettingsResetter::TagForResetting(Profile* profile) {
DCHECK(profile);
RecordResetPending(true, profile);
+ UMA_HISTOGRAM_ENUMERATION("SoftwareReporter.TaggedProfileForResetting",
+ TAGGED_PROFILE_FOR_RESETTING_TAGGED,
+ TAGGED_PROFILE_FOR_RESETTING_MAX);
}
void PostCleanupSettingsResetter::ResetTaggedProfiles(
@@ -237,6 +247,9 @@ void PostCleanupSettingsResetter::ResetTaggedProfiles(
return;
}
+ UMA_HISTOGRAM_EXACT_LINEAR("SoftwareReporter.PostCleanupSettingsReset",
+ profiles_to_reset.size(), 10);
+
// The SettingsResetter object will self-delete once |done_callback| is
// invoked.
make_scoped_refptr(new SettingsResetter(std::move(profiles_to_reset),

Powered by Google App Engine
This is Rietveld 408576698