Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc

Issue 2973873002: Primary histograms for InBrowserCleanerUI experiment (Closed)
Patch Set: Histograms and enums Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
index 3c63d8bc4a5df2ca0d4e7b0573455c9d95000774..4c921517e62bd92c4d3d282d81f14527055ea35c 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
+++ b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
@@ -15,6 +15,7 @@
#include "base/callback_helpers.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/metrics/histogram_macros.h"
#include "base/sequence_checker.h"
#include "base/synchronization/lock.h"
#include "base/win/registry.h"
@@ -165,8 +166,9 @@ void SettingsResetter::OnResetCompleted(Profile* profile) {
RecordResetPending(false, profile);
--num_pending_resets_;
- if (!num_pending_resets_)
+ if (!num_pending_resets_) {
csharp 2017/07/07 17:32:51 nit: No need for the braces since this is a single
ftirelo 2017/07/07 20:27:53 Done.
std::move(done_callback_).Run();
+ }
}
// Returns true if there is information of a completed cleanup in the registry.
@@ -220,6 +222,7 @@ void PostCleanupSettingsResetter::TagForResetting(Profile* profile) {
DCHECK(profile);
RecordResetPending(true, profile);
+ UMA_HISTOGRAM_BOOLEAN("SoftwareReporter.TaggedProfileForResetting", true);
}
void PostCleanupSettingsResetter::ResetTaggedProfiles(
@@ -237,6 +240,9 @@ void PostCleanupSettingsResetter::ResetTaggedProfiles(
return;
}
+ UMA_HISTOGRAM_EXACT_LINEAR("SoftwareReporter.PostCleanupSettingsReset",
+ profiles_to_reset.size());
+
// The SettingsResetter object will self-delete once |done_callback| is
// invoked.
make_scoped_refptr(new SettingsResetter(std::move(profiles_to_reset),

Powered by Google App Engine
This is Rietveld 408576698