Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5007)

Unified Diff: chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc

Issue 2973873002: Primary histograms for InBrowserCleanerUI experiment (Closed)
Patch Set: Revert changes to histogram.cc Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
index e786d4c37ebd464958b35690aded140ebd5a9a38..cf30906ef62a4597cb4ea98d6b124cc61f18a077 100644
--- a/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
+++ b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
@@ -8,6 +8,7 @@
#include "base/command_line.h"
#include "base/feature_list.h"
+#include "base/metrics/histogram_macros.h"
#include "base/synchronization/lock.h"
#include "base/values.h"
#include "chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h"
@@ -143,6 +144,7 @@ void ChromeCleanupHandler::HandleRegisterChromeCleanerObserver(
DCHECK(
base::FeatureList::IsEnabled(safe_browsing::kInBrowserCleanerUIFeature));
+ UMA_HISTOGRAM_BOOLEAN("SoftwareReporter.CleanupCard", true);
AllowJavascript();
// Send the current logs upload state.
@@ -175,6 +177,8 @@ void ChromeCleanupHandler::HandleStartCleanup(const base::ListValue* args) {
// The state is propagated to all open tabs and should be consistent.
DCHECK_EQ(controller_->logs_enabled(), allow_logs_upload);
+ safe_browsing::RecordCleanupStartedHistogram(
+ safe_browsing::CLEANUP_STARTED_FROM_PROMPT_IN_SETTINGS);
controller_->ReplyWithUserResponse(
profile_,
allow_logs_upload
« no previous file with comments | « chrome/browser/safe_browsing/chrome_cleaner/srt_global_error_win.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698