Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3218)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h

Issue 2973873002: Primary histograms for InBrowserCleanerUI experiment (Closed)
Patch Set: Revert changes to histogram.cc Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h b/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
index 6809423214eaa36e4d2b728ea53bc8d00db5590f..ff3c316d2dba14f263babc3af1d75b7986c96804 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
+++ b/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
@@ -26,6 +26,21 @@ enum SRTPromptHistogramValue {
SRT_PROMPT_MAX,
};
+// These values are used to send UMA information and are replicated in the
+// histograms.xml file, so the order MUST NOT CHANGE.
+enum NoPromptReasonHistogramValue {
+ NO_PROMPT_REASON_BEHAVIOUR_NOT_SUPPORTED = 0,
+ NO_PROMPT_REASON_FEATURE_NOT_ENABLED = 1,
+ NO_PROMPT_REASON_NOTHING_FOUND = 2,
+ NO_PROMPT_REASON_ALREADY_PROMPTED = 3,
+ NO_PROMPT_REASON_CLEANER_DOWNLOAD_FAILED = 4,
+ NO_PROMPT_REASON_BROWSER_NOT_AVAILABLE = 5,
+ NO_PROMPT_REASON_NOT_ON_IDLE_STATE = 6,
+ NO_PROMPT_REASON_IPC_CONNECTION_BROKEN = 7,
+
+ NO_PROMPT_REASON_MAX,
+};
+
// When enabled, all user interaction with the Chrome Cleaner will happen from
// within Chrome.
extern const base::Feature kInBrowserCleanerUIFeature;
@@ -51,6 +66,15 @@ std::string GetIncomingSRTSeed();
// Records a value for the SRT Prompt Histogram.
void RecordSRTPromptHistogram(SRTPromptHistogramValue value);
+// Records a SoftwareReporter.PromptShown histogram with value true.
+void RecordPromptShownHistogram();
+
+// Records a SoftwareReporter.PromptShown histogram with value false and
+// a SoftwareReporter.NoPromptReason histogram with the reason corresponding
+// to |value|.
+void RecordPromptNotShownWithReasonHistogram(
+ NoPromptReasonHistogramValue value);
+
} // namespace safe_browsing
#endif // CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_SRT_FIELD_TRIAL_WIN_H_

Powered by Google App Engine
This is Rietveld 408576698