tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 22767c98fe9e175ccd0914a6785f38ec5c90a16e..8c2a1c6586bc8b49fe9f4f2c8f4c6c0444d5f7b5 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -73254,6 +73254,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.Cleaner.CleanupResult"
+    enum="SoftwareReporterCleanupResult">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The final status of the Chrome Cleanup Tool run (e.g. succeeded, failed,
+    reboot required).
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.Cleaner.DownloadStatus"
+    enum="SoftwareReporterCleanerDownloadStatus">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    An indication if an attempt to download the Chrome Cleanup Tool succeeded
+    or the reason why it failed.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.Cleaner.HasCompleted" enum="SRTCompleted">
   <owner>mad@chromium.org</owner>
   <summary>
@@ -73271,6 +73289,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.Cleaner.RebootResponse"
+    units="SoftwareReporterCleanerRebootResponse">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Indicates that the user accepted to initiate a reboot to complete a run

[rkaplow, 2017/07/10 14:23:06]

similar to comment below - can you track when they did not initiate as well?

Can you also mention when this is logged

[ftirelo, 2017/07/10 19:08:51]

The reboot can happen at any moment in the future, so we can't track when it's
not initiated. Added this to the description along with when it's logged.

+    of the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.Cleaner.RunningTime" units="ms">
   <owner>mad@chromium.org</owner>
   <summary>How long it took to run the software reporter cleaner tool.</summary>
@@ -73281,6 +73308,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <summary>The build version of the software reporter cleaner tool.</summary>
 </histogram>
 
+<histogram name="SoftwareReporter.CleanerLogsAcceptance" units="boolean">

[rkaplow, 2017/07/10 14:34:53]

also this should be enum=Boolean

[ftirelo, 2017/07/10 19:08:51]

Done.

+  <owner>ftirelo@chromium.org</owner>
+  <summary>

[rkaplow, 2017/07/10 14:23:05]

mention when this is logged

[ftirelo, 2017/07/10 19:08:51]

Done.

+    Whether the user accepted to upload logs from Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.CleanupCard"
+    enum="SoftwareReporterCleanupCard">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the Chrome Cleanup Tool card in the Settings page has been shown.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.CleanupStarted"
+    enum="SoftwareReporterCleanupStarted">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Indicates where the user started a cleanup from (e.g. from the prompt
+    dialog or the settings page).
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.ExperimentErrors"
     enum="SoftwareReporterExperimentError">
   <owner>joenotcharles@chromium.org</owner>
@@ -73298,6 +73349,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.IPCConnectionError"
+    enum="SoftwareReporterIPCConnectionError">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Indicates IPC connection errors between Chrome and the Chrome Cleanup Tool.

[rkaplow, 2017/07/10 14:23:06]

mention when it is logged. Should you also have a bucket when there was no IPC
error or is that not useful?

[ftirelo, 2017/07/10 19:08:51]

It might be, and it's not hard to log. Changed to include success.

+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.LastUploadResult" enum="BooleanSuccess">
   <owner>mad@chromium.org</owner>
   <summary>The result of the most recent SRT log upload.</summary>
@@ -73358,6 +73417,46 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.NoPromptReason"
+    enum="SoftwareReporterNoPromptReason">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The reason why the user has not been prompted to run the Chrome Cleanup
+    Tool (e.g. no unwanted software found, user recently prompted).
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.NumberOfFilesToDelete">

[rkaplow, 2017/07/10 14:23:05]

add unit

[ftirelo, 2017/07/10 19:08:51]

Done.

+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The number of files to be deleted by the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PostCleanupSettingsReset">

[rkaplow, 2017/07/10 14:23:06]

unit

[ftirelo, 2017/07/10 19:08:51]

Done.

+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The number of profiles whose settings will be reset once a successful
+    cleanup completes.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PromptDialogResponse"
+    enum="SoftwareReporterPromptDialogResponse">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The user response on the modal Chrome Cleanup Tool prompt dialog
+    (e.g. accepted, cancelled).
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PromptShown" units="boolean">

[rkaplow, 2017/07/10 14:34:53]

also enum=Boolean

[ftirelo, 2017/07/10 19:08:51]

Done.

+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the user has been prompted to run the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.PromptUsage" enum="SRTPromptUsage">
   <owner>mad@chromium.org</owner>
   <summary>Usage of the Software Removal Tool (SRT) Prompt.</summary>
@@ -73396,6 +73495,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.TaggedProfileForResetting"

[rkaplow, 2017/07/10 14:23:06]

it's not disallowed, but it's best when there is multiple enum buckets - for
example to do some sort of baselining. Wondering it if makes sense to track a
negative case here - i.e. when a profile wasn't tagged. Just a suggestion if
that sort of baselining can make sense for your case

[ftirelo, 2017/07/10 19:08:51]

Could you help us figure out the best approach here?

Profiles are always tagged. Our goal is to compare this with
PostCleanupSettingsReset, in order to know the ratio of tagged profiles that are
actually reset. Using a single histogram for that doesn't seem right, because we
can't log the negative case - a reset can happen several hours after a profile
is tagged (e.g. a cleanup may require a reboot and reset will only happen next
time the user opens the browser post-reboot).

[rkaplow, 2017/07/11 14:10:52]

I actually don't see why that would be a problem - in that case the aggregate
metric would still make sense right? (although you wouldn't be able to look at a
single user with high accuracy).

+    enum="SoftwareReporterTaggedProfileForResetting">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Registers when a profile is tagged for settings reset before a run of
+    the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.UploadFailureCount">
   <owner>mad@chromium.org</owner>
   <summary>