Primary histograms for InBrowserCleanerUI experiment

chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/chrome_cleanup_handler.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/synchronization/lock.h"
 #include "base/values.h"
 #include "chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using safe_browsing::ChromeCleanerController;
 
@@ skipping 25 matching lines @@
       return "user_declined_cleanup";
     case ChromeCleanerController::IdleReason::kCleaningFailed:
       return "cleaning_failed";
     case ChromeCleanerController::IdleReason::kCleaningSucceeded:
       return "cleaning_succeeded";
   }
   NOTREACHED();
   return "";
 }
 
+enum CleanupCardHistogramValue {

[csharp, 2017/07/07 20:53:33]

nit: Add a comment about how this needs to match uma

[ftirelo, 2017/07/07 21:22:08]

Done.

+  CLEANUP_CARD_SHOWN = 0,
+
+  CLEANUP_CARD_MAX,
+};
+
 }  // namespace
 
 ChromeCleanupHandler::ChromeCleanupHandler(Profile* profile)
     : controller_(ChromeCleanerController::GetInstance()), profile_(profile) {}
 
 ChromeCleanupHandler::~ChromeCleanupHandler() {
   controller_->RemoveObserver(this);
 }
 
 void ChromeCleanupHandler::RegisterMessages() {
@@ skipping 60 matching lines @@
 }
 
 void ChromeCleanupHandler::HandleRegisterChromeCleanerObserver(
     const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
   // The Polymer element should never be attached if the feature is
   // disabled.
   DCHECK(
       base::FeatureList::IsEnabled(safe_browsing::kInBrowserCleanerUIFeature));
 
+  UMA_HISTOGRAM_ENUMERATION("SoftwareReporter.CleanupCard", CLEANUP_CARD_SHOWN,
+                            CLEANUP_CARD_MAX);
   AllowJavascript();
 }
 
 void ChromeCleanupHandler::HandleRestartComputer(const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
 
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::Value("chrome-cleanup-on-dismiss"));
   // TODO(proberge): Show a prompt to reboot the system.
 }
 
 void ChromeCleanupHandler::HandleStartCleanup(const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
 
+  safe_browsing::RecordCleanupStartedHistogram(
+      safe_browsing::CLEANUP_STARTED_FROM_PROMPT_IN_SETTINGS);
   controller_->ReplyWithUserResponse(
       // TODO(proberge): Send kAcceptedWithLogs or kAcceptedWithoutLogs based on
       // the state of a logs upload permissions checkbox.
       profile_, ChromeCleanerController::UserResponse::kAcceptedWithoutLogs);
 }
 
 }  // namespace settings