tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 0d49c382350407dc20956de4b9b4eeb92446c84d..99347d4459b8f103ed0aeac2051377ed99f27382 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -72942,6 +72942,38 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <summary>The build version of the software reporter cleaner tool.</summary>
 </histogram>
 
+<histogram name="SoftwareReporter.CleanerDownloadStatus"
+    enum="SoftwareReporterCleanerDownloadStatus">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    An indication if an attempt to download the Chrome Cleanup Tool succeeded
+    or the reason why it failed.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.CleanerLogsAcceptance" units="boolean">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the user accepted to upload logs from Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.CleanupCardShown" units="boolean">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the Chrome Cleanup Tool card in the Settings page has been shown.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.CleanupStarted"
+    enum="SoftwareReporterCleanupStarted">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Indicates where the user started a cleanup from (e.g. from the prompt
+    dialog or the settings page).
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.ExperimentErrors"
     enum="SoftwareReporterExperimentError">
   <owner>joenotcharles@chromium.org</owner>
@@ -73019,11 +73051,66 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.NoPromptReason"
+    enum="SoftwareReporterNoPromptReason">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The reason why the user has not been prompted to run the Chrome Cleanup
+    Tool (e.g. no unwanted software found, user recently prompted).
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.NumberOfFilesToDelete">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The number of files to be deleted by the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PostCleanupSettingsReset">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The number of profiles whose settings will be reset once a successful
+    cleanup completes.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PromptDialogResponse"
+    enum="SoftwareReporterPromptDialogResponse">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    The user response on the modal Chrome Cleanup Tool prompt dialog
+    (e.g. accepted, cancelled).
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.PromptShown" units="boolean">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the user has been prompted to run the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.PromptUsage" enum="SRTPromptUsage">
   <owner>mad@chromium.org</owner>
   <summary>Usage of the Software Removal Tool (SRT) Prompt.</summary>
 </histogram>
 
+<histogram name="SoftwareReporter.RebootInitiated" units="boolean">

[csharp, 2017/07/07 17:32:51]

These last 3 new histograms only seem to ever get the value true set. If this is
just for counting, they should probably be converted to enums as previous
suggested.

Although I think RebootRequired and TaggedProfile* both make sense to stay as
bools, but they should get their false values recorded.

[ftirelo, 2017/07/07 20:27:53]

Replaced RebootRequired with CleanupStatus, which is more general.
TaggedProfile* was replaced with an enum since we always tag profiles for
resetting.

+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the user accepted to initiate a reboot to complete a run of the
+    Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
+<histogram name="SoftwareReporter.RebootRequired" units="boolean">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the Chrome Cleanup Tool requires a reboot to finish a cleanup.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.RunningTime" units="ms">
   <owner>alito@chromium.org</owner>
   <summary>
@@ -73057,6 +73144,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SoftwareReporter.TaggedProfileForResetting" units="boolean">
+  <owner>ftirelo@chromium.org</owner>
+  <summary>
+    Whether the current profile is tagged for settings reset before a run of
+    the Chrome Cleanup Tool.
+  </summary>
+</histogram>
+
 <histogram name="SoftwareReporter.UploadFailureCount">
   <owner>mad@chromium.org</owner>
   <summary>