tools/metrics/histograms/enums.xml

Index: tools/metrics/histograms/enums.xml
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 9a8c6884635fc8ee7cfe8af50565c3d0fe5bac2a..69bbf7d0f773677d0aa7c020dafb413a94f41fca 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -34153,6 +34153,18 @@ from previous Chrome versions.
   <int value="4" label="Used, relocked"/>
 </enum>
 

[csharp, 2017/07/07 17:32:51]

What do you think about change SoftwareReporter -> ChromeCleaner for the cases
where it is the cleaner and not the reporter?

Like SoftwareReporterCleanerDownloadStatus -> ChromeCleanerDownloadStatus

Or Maybe still prefix it with SoftwareReporter to group with the others

[ftirelo, 2017/07/07 20:27:53]

As discussed, we have several histograms prefixed with SoftwareReporter.Cleaner.
Even though it's not ideal, we can't get rid of all legacy analysis, so I'll
keep naming consistent.

+<enum name="SoftwareReporterCleanerDownloadStatus">
+  <int value="0" label="Succeeded"/>
+  <int value="1" label="Other failure"/>
+  <int value="2" label="Not found on server"/>
+  <int value="3" label="Failed to create temporary directory"/>
+</enum>
+
+<enum name="SoftwareReporterCleanupStarted">
+  <int value="1" label="From prompt dialog"/>
+  <int value="2" label="From prompt in Settings"/>
+</enum>
+
 <enum name="SoftwareReporterExperimentError">
   <int value="1" label="Bad tag"/>
   <int value="2" label="Bad parameters"/>
@@ -34181,6 +34193,25 @@ from previous Chrome versions.
   <int value="3" label="Value out of bounds"/>
 </enum>
 
+<enum name="SoftwareReporterNoPromptReason">
+  <int value="0" label="Behaviour not supported"/>
+  <int value="1" label="Feature not enabled"/>
+  <int value="2" label="Nothing found"/>
+  <int value="3" label="Already prompted"/>
+  <int value="4" label="Recently prompted"/>

[csharp, 2017/07/07 17:32:51]

Where is recently prompted used and how it is different from already prompted?

[ftirelo, 2017/07/07 20:27:53]

Good catch! Removed.

+  <int value="5" label="Cleaner download failed"/>
+  <int value="6" label="Browser not available"/>
+  <int value="7" label="Not on idle state"/>
+  <int value="8" label="IPC connection broken"/>
+</enum>
+
+<enum name="SoftwareReporterPromptDialogResponse">
+  <int value="0" label="Accepted"/>
+  <int value="2" label="Details"/>
+  <int value="3" label="Cancelled"/>
+  <int value="4" label="Dismissed"/>
+</enum>
+
 <enum name="SpareWebContentsStatus">
   <int value="0" label="Created"/>
   <int value="1" label="Used"/>