base/metrics/statistics_recorder_unittest.cc - Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/statistics_recorder_unittest.cc

Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Patch Set: never rely on outside string permanence Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/statistics_recorder_unittest.cc

diff --git a/base/metrics/statistics_recorder_unittest.cc b/base/metrics/statistics_recorder_unittest.cc

index c581f15bc59038de3a32e97e63869482fa8851f4..fb4d95bd97c698a85430d7b884cb600ffffc1b31 100644

--- a/base/metrics/statistics_recorder_unittest.cc

+++ b/base/metrics/statistics_recorder_unittest.cc

@@ -77,7 +77,7 @@ class StatisticsRecorderTest : public testing::TestWithParam<bool> {

StatisticsRecorder::UninitializeForTesting();

}

- Histogram* CreateHistogram(const std::string& name,

+ Histogram* CreateHistogram(const char* name,

HistogramBase::Sample min,

HistogramBase::Sample max,

size_t bucket_count) {