extensions/browser/value_store/leveldb_value_store.cc - Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/leveldb_value_store.cc

Issue 2973863002: Remove std::string histogram name from HistogramBase object.

Patch Set: rebased Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/value_store/leveldb_value_store.cc

diff --git a/extensions/browser/value_store/leveldb_value_store.cc b/extensions/browser/value_store/leveldb_value_store.cc

index c0e133bfa9657cf9843e3d508b74ad84bcb0411c..78dc43bb4c0ffda32224b5bc1ff318e586615ef9 100644

--- a/extensions/browser/value_store/leveldb_value_store.cc

+++ b/extensions/browser/value_store/leveldb_value_store.cc

@@ -254,7 +254,7 @@ bool LeveldbValueStore::OnMemoryDump(

DCHECK(res);

auto* dump = pmd->CreateAllocatorDump(base::StringPrintf(

- "leveldb/value_store/%s/0x%" PRIXPTR, open_histogram_name().c_str(),

+ "leveldb/value_store/%s/0x%" PRIXPTR, open_histogram_name(),

reinterpret_cast<uintptr_t>(this)));

dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,

base::trace_event::MemoryAllocatorDump::kUnitsBytes, size);