Remove std::string histogram name from HistogramBase object.

base/metrics/histogram_snapshot_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_snapshot_manager.h"
 
 #include <memory>
 
 #include "base/debug/alias.h"
 #include "base/metrics/histogram_flattener.h"
@@ skipping 67 matching lines @@
   if (HistogramBase::BUCKET_ORDER_ERROR & corruption) {
     // Extract fields useful during debug.
     const BucketRanges* ranges =
         static_cast<const Histogram*>(histogram)->bucket_ranges();
     std::vector<HistogramBase::Sample> ranges_copy;
     for (size_t i = 0; i < ranges->size(); ++i)
       ranges_copy.push_back(ranges->range(i));
     HistogramBase::Sample* ranges_ptr = &ranges_copy[0];
     uint32_t ranges_checksum = ranges->checksum();
     uint32_t ranges_calc_checksum = ranges->CalculateChecksum();
-    const char* histogram_name = histogram->histogram_name().c_str();
+    const char* histogram_name = histogram->histogram_name();
     int32_t flags = histogram->flags();
     // The checksum should have caught this, so crash separately if it didn't.
     CHECK_NE(0U, HistogramBase::RANGE_CHECKSUM_ERROR & corruption);
     CHECK(false);  // Crash for the bucket order corruption.
     // Ensure that compiler keeps around pointers to |histogram| and its
     // internal |bucket_ranges_| for any minidumps.
     base::debug::Alias(&ranges_ptr);
     base::debug::Alias(&ranges_checksum);
     base::debug::Alias(&ranges_calc_checksum);
     base::debug::Alias(&histogram_name);
@@ skipping 14 matching lines @@
       return;  // We've already seen this corruption for this histogram.
     sample_info->inconsistencies |= corruption;
     return;
   }
 
   if (samples->TotalCount() > 0)
     histogram_flattener_->RecordDelta(*histogram, *samples);
 }
 
 }  // namespace base