Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2973753003: Initial documentation for the plugin package (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, mfairhurst
CC:
reviews_dartlang.org, mfairhurst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -0 lines) Patch
M pkg/analyzer_plugin/README.md View 2 chunks +13 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/assists.md View 1 chunk +106 lines, -0 lines 1 comment Download
A pkg/analyzer_plugin/doc/tutorial/completion.md View 1 chunk +81 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/creating_edits.md View 1 chunk +205 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/fixes.md View 1 chunk +121 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/getting_started.md View 1 chunk +39 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/tutorial.md View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-06 16:26:30 UTC) #2
devoncarew
lgtm Looks great!
3 years, 5 months ago (2017-07-06 18:21:35 UTC) #3
devoncarew
CC'ing Mike, as he may have some comments, from an implementers perspective.
3 years, 5 months ago (2017-07-06 18:22:50 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 0484f2833573c3ac3818e62f2d65ab6f3d7daaeb (presubmit successful).
3 years, 5 months ago (2017-07-06 18:37:56 UTC) #6
Brian Wilkerson
I'm happy to get more feedback and improve the docs, but I've committed so that ...
3 years, 5 months ago (2017-07-06 18:38:56 UTC) #7
mfairhurst
3 years, 5 months ago (2017-07-07 13:45:46 UTC) #9
Message was sent while issue was closed.
lgtm

Agreed with Devon -- this is really really great documentation. Really really
appreciate this Brian!! As I'm sure all plugin implementors will as well.

https://codereview.chromium.org/2973753003/diff/1/pkg/analyzer_plugin/doc/tut...
File pkg/analyzer_plugin/doc/tutorial/assists.md (right):

https://codereview.chromium.org/2973753003/diff/1/pkg/analyzer_plugin/doc/tut...
pkg/analyzer_plugin/doc/tutorial/assists.md:100: covariant AnalysisDriver
driver) {
I think in this case "covariant" is not needed

Powered by Google App Engine
This is Rietveld 408576698