Issue 297373002: Fix memory leak in the debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297373002: Fix memory leak in the debugger. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/debug.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/isolate.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

Please take a look. The leak is a result of the change here: https://codereview.chromium.org/299653002/diff/40001/src/isolate.cc

6 years, 6 months ago (2014-05-26 07:23:11 UTC) #1

Yang

6 years, 6 months ago (2014-05-26 08:05:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21479 (presubmit successful).