Issue 2973673002: Fix a bug in inline method refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2973673002: Fix a bug in inline method refactoring (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson

Modified:
3 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/util.dart	View		1 chunk	+10 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/services/refactoring/inline_method_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Brian Wilkerson

I'm hoping that there's a better way to fix the bug and that you can ...

3 years, 5 months ago (2017-07-05 16:13:38 UTC) #2

Brian Wilkerson

I do, but I don't really want to implement "isAssociative" for all expressions right now.

3 years, 5 months ago (2017-07-05 16:35:39 UTC) #4

Brian Wilkerson

3 years, 5 months ago (2017-07-05 16:35:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62f43f663b76715b45249987570632ba267e8b3c (presubmit successful).