Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2973643002: Cache the override for WebRTC's AEC3 in RenderProcessHostImpl (Closed)
Patch Set: Add a TODO Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 32ad1d579ee0d5ffd5b0ce243c26900e571b4c77..045df34d88cf1a9bfb8ea1d1d742351fdd7c0322 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -2914,6 +2914,10 @@ bool RenderProcessHostImpl::StopWebRTCEventLog() {
void RenderProcessHostImpl::SetEchoCanceller3(bool enable) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ // TODO(hlundin) Implement a test to verify that the setting works both with
+ // aec_dump_consumers already registered, and with those registered in the
+ // future. crbug.com/740104
+ override_aec3_ = enable;
// Piggybacking on AEC dumps.
// TODO(hlundin): Change name for aec_dump_consumers_;
@@ -3746,6 +3750,9 @@ void RenderProcessHostImpl::RegisterAecDumpConsumerOnUIThread(int id) {
WebRTCInternals::GetInstance()->GetAudioDebugRecordingsFilePath());
EnableAecDumpForId(file_with_extensions, id);
}
+ if (override_aec3_) {
+ Send(new AudioProcessingMsg_EnableAec3(id, *override_aec3_));
+ }
}
void RenderProcessHostImpl::UnregisterAecDumpConsumerOnUIThread(int id) {
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698