Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2973633002: [kernel] Change how TypeParameterType is calculated. (Closed)
Patch Set: Rebased Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/binary/ast_to_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart
index 7c63b495c1b1f54033558d2ade3f5be33a4d0d93..0c54fce565111edc79ec20b1ca7001aa9b8084f9 100644
--- a/pkg/kernel/lib/binary/ast_to_binary.dart
+++ b/pkg/kernel/lib/binary/ast_to_binary.dart
@@ -1144,10 +1144,6 @@ class BinaryPrinter extends Visitor {
visitTypeParameterType(TypeParameterType node) {
writeByte(Tag.TypeParameterType);
writeUInt30(_typeParameterIndexer[node.parameter]);
- List<TypeParameter> typeParameters =
- _typeParameterIndexer.indexList[node.parameter];
- writeUInt30(typeParameters[0].binaryOffset);
- writeUInt30(typeParameters.indexOf(node.parameter));
writeOptionalNode(node.promotedBound);
}
@@ -1263,14 +1259,11 @@ class SwitchCaseIndexer {
class TypeParameterIndexer {
final Map<TypeParameter, int> index = <TypeParameter, int>{};
- final Map<TypeParameter, List<TypeParameter>> indexList =
- <TypeParameter, List<TypeParameter>>{};
int stackHeight = 0;
void enter(List<TypeParameter> typeParameters) {
for (var parameter in typeParameters) {
index[parameter] = stackHeight;
- indexList[parameter] = typeParameters;
++stackHeight;
}
}

Powered by Google App Engine
This is Rietveld 408576698