[kernel] Change how TypeParameterType is calculated.

runtime/vm/kernel_binary_flowgraph.h

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
 #define RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
 
 #include <map>
@@ skipping 39 matching lines @@
 
   class TypeParameterScope {
    public:
     TypeParameterScope(StreamingDartTypeTranslator* translator,
                        intptr_t parameters_offset,
                        intptr_t parameters_count)
         : parameters_offset_(parameters_offset),
           parameters_count_(parameters_count),
           outer_(translator->type_parameter_scope_),
           translator_(translator) {
+      summed_outer_parameters_count_ = 0;

[Kevin Millikin (Google), 2017/08/08 14:08:51]

summed_ seems like a noise word and I wouldn't make it plural if I was using
count, so: outer_parameter_count_.

[jensj, 2017/08/09 08:39:47]

Done.

+      if (outer_ != NULL) {
+        summed_outer_parameters_count_ =
+            outer_->summed_outer_parameters_count_ + outer_->parameters_count_;
+      }
       translator_->type_parameter_scope_ = this;
     }
     ~TypeParameterScope() { translator_->type_parameter_scope_ = outer_; }
 
     TypeParameterScope* outer() const { return outer_; }
     intptr_t parameters_offset() const { return parameters_offset_; }
     intptr_t parameters_count() const { return parameters_count_; }
+    intptr_t summed_outer_parameters_count() const {
+      return summed_outer_parameters_count_;
+    }
 
    private:
     intptr_t parameters_offset_;
     intptr_t parameters_count_;
+    intptr_t summed_outer_parameters_count_;
     TypeParameterScope* outer_;
     StreamingDartTypeTranslator* translator_;
   };
 
   intptr_t FindTypeParameterIndex(intptr_t parameters_offset,
                                   intptr_t parameters_count,
                                   intptr_t look_for);
 
   StreamingFlowGraphBuilder* builder_;
   TranslationHelper& translation_helper_;
@@ skipping 258 matching lines @@
       GrowableArray<intptr_t>* record_token_positions_in,
       GrowableArray<intptr_t>* record_yield_positions_in);
   intptr_t SourceTableSize();
   String& SourceTableUriFor(intptr_t index);
   String& GetSourceFor(intptr_t index);
   Array& GetLineStartsFor(intptr_t index);
 
  private:
   void DiscoverEnclosingElements(Zone* zone,
                                  const Function& function,
-                                 Function* outermost_function,
-                                 intptr_t* outermost_kernel_offset,
-                                 intptr_t* parent_class_offset);
-  intptr_t GetParentOffset(intptr_t offset);
-  void GetTypeParameterInfoForClass(intptr_t class_offset,
-                                    intptr_t* type_paremeter_counts,
-                                    intptr_t* type_paremeter_offset);
+                                 Function* outermost_function);
 
-  void GetTypeParameterInfoForPossibleProcedure(
-      intptr_t outermost_kernel_offset,
-      bool* member_is_procedure,
-      bool* is_factory_procedure,
-      intptr_t* member_type_parameters,
-      intptr_t* member_type_parameters_offset_start);
   /**
    * Will return kernel offset for parent class if reading a constructor.
    * Will otherwise return -1.
    */
   intptr_t ReadUntilFunctionNode();
   StringIndex GetNameFromVariableDeclaration(intptr_t kernel_offset);
 
   FlowGraph* BuildGraphOfStaticFieldInitializer();
   FlowGraph* BuildGraphOfFieldAccessor(LocalVariable* setter_value);
   void SetupDefaultParameterValues();
@@ skipping 1171 matching lines @@
  private:
   Reader* reader_;
   intptr_t saved_offset_;
 };
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 #endif  // RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_