Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2973603004: Mark failing test as failing. (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 5 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Also fails on Safari. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
TBR
3 years, 5 months ago (2017-07-06 08:25:39 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 38625a1a3488b4b3440c11bb4e32d79bf594adbb (presubmit successful).
3 years, 5 months ago (2017-07-06 08:25:53 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 41748963329106fc9195b11c77945cbc50712d55 (presubmit successful).
3 years, 5 months ago (2017-07-06 10:59:17 UTC) #6
cbernaschina
3 years, 5 months ago (2017-07-06 20:13:59 UTC) #7
Message was sent while issue was closed. 
On 2017/07/06 10:59:17, Lasse Reichstein Nielsen wrote:
> Committed patchset #2 (id:20001) manually as
> 41748963329106fc9195b11c77945cbc50712d55 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698