Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: base/metrics/histogram_samples.h

Issue 2973603002: Remove typically unused local_metadata_ field. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/histogram_samples.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_samples.h
diff --git a/base/metrics/histogram_samples.h b/base/metrics/histogram_samples.h
index cc27d3dd8abe1de30c221417e7d39b1b433a01a9..e6257dac9dfcf5561b1b6d4f77b68a15ddfd1d4c 100644
--- a/base/metrics/histogram_samples.h
+++ b/base/metrics/histogram_samples.h
@@ -128,7 +128,6 @@ class BASE_EXPORT HistogramSamples {
LocalMetadata();
};
- explicit HistogramSamples(uint64_t id);
HistogramSamples(uint64_t id, Metadata* meta);
virtual ~HistogramSamples();
@@ -180,11 +179,9 @@ class BASE_EXPORT HistogramSamples {
return meta_->single_sample;
}
+ Metadata* meta() { return meta_; }
+
private:
- // In order to support histograms shared through an external memory segment,
- // meta values may be the local storage or external storage depending on the
- // wishes of the derived class.
- LocalMetadata local_meta_;
Metadata* meta_;
DISALLOW_COPY_AND_ASSIGN(HistogramSamples);
« no previous file with comments | « no previous file | base/metrics/histogram_samples.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698