Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 297353002: Remove RaisesException from getCurrentPosition and watchPosition (Closed)

Created:
6 years, 6 months ago by kihong
Modified:
6 years, 6 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove RaisesException from getCurrentPosition and watchPosition According to Geolocation API specification getCurrentPosition and watchPosition does not raise exception, and current RaisesException for them in the Geolocation.idl are meaningless Because it never affect to generating bindings codes at all. Therefore we do not need to keep them in that idl. BUG=368184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175133

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/modules/geolocation/Geolocation.idl View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kihong
6 years, 6 months ago (2014-05-26 04:41:53 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-30 00:50:28 UTC) #2
kihong
The CQ bit was checked by kihong.kwon@samsung.com
6 years, 6 months ago (2014-05-30 00:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/297353002/20001
6 years, 6 months ago (2014-05-30 00:57:39 UTC) #4
kihong
The CQ bit was unchecked by kihong.kwon@samsung.com
6 years, 6 months ago (2014-05-30 13:25:49 UTC) #5
kihong
The CQ bit was checked by kihong.kwon@samsung.com
6 years, 6 months ago (2014-05-30 13:25:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/297353002/20001
6 years, 6 months ago (2014-05-30 13:26:06 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:20:43 UTC) #8
Message was sent while issue was closed.
Change committed as 175133

Powered by Google App Engine
This is Rietveld 408576698