ui/views/cocoa/bridged_content_view.mm - Issue 2973463002: MacViews: Don't InsertChar() for consumed events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2973463002: MacViews: Don't InsertChar() for consumed events. (Closed)

Patch Set: Rebase (patch failure due to r484422) Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_content_view.mm

diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm

index 46e34d86737b6a9716db18835ad7ea1b38f59c4d..e300b7e245c66c6c540e10f4df6ee48ca84dfd88 100644

--- a/ui/views/cocoa/bridged_content_view.mm

+++ b/ui/views/cocoa/bridged_content_view.mm

@@ -530,6 +530,8 @@ ui::TextEditCommand GetTextEditCommandForMenuAction(SEL action) {

ui::EF_NONE);

[self handleKeyEvent:&charEvent];

hasUnhandledKeyDownEvent_ = NO;

+ if (charEvent.handled())

+ return;

}

// Forward the |text| to |textInputClient_| if no menu is active.

« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield_unittest.cc » ('j') | no next file with comments »