Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.cc

Issue 2973433003: Block redirects to renderer-debug urls. (Closed)
Patch Set: Addressed comment (@clamy) Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/child_process_security_policy_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_tab_helper.cc
diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.cc b/chrome/browser/captive_portal/captive_portal_tab_helper.cc
index 647cc62728950da07115f606adf4d32132fabf0a..6f7262577d867759b5a3c91fb355ff99737231dd 100644
--- a/chrome/browser/captive_portal/captive_portal_tab_helper.cc
+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.cc
@@ -63,8 +63,8 @@ void CaptivePortalTabHelper::DidStartNavigation(
return;
}
- // TODO(clamy): Remove this when we understand the root cause behind
- // crbug.com/704892.
+ // TODO(clamy): The root cause behind crbug.com/704892 is known.
+ // Remove this code if it is never reached until ~ 2017-July-20.
if (navigation_handle == navigation_handle_)
base::debug::DumpWithoutCrashing();
@@ -96,11 +96,6 @@ void CaptivePortalTabHelper::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- // TODO(clamy): Remove this when we understand the root cause behind
- // crbug.com/704892.
- if (navigation_handle_ && !navigation_handle_->IsInMainFrame())
- base::debug::DumpWithoutCrashing();
-
// Exclude subframe navigations.
if (!navigation_handle->IsInMainFrame())
return;
« no previous file with comments | « no previous file | content/browser/child_process_security_policy_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698