Chromium Code Reviews| Index: chrome/browser/captive_portal/captive_portal_tab_helper.cc |
| diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.cc b/chrome/browser/captive_portal/captive_portal_tab_helper.cc |
| index 647cc62728950da07115f606adf4d32132fabf0a..825dacf6cc9ac0efb538c30fce5c42da2962cdb1 100644 |
| --- a/chrome/browser/captive_portal/captive_portal_tab_helper.cc |
| +++ b/chrome/browser/captive_portal/captive_portal_tab_helper.cc |
| @@ -63,8 +63,8 @@ void CaptivePortalTabHelper::DidStartNavigation( |
| return; |
| } |
| - // TODO(clamy): Remove this when we understand the root cause behind |
| - // crbug.com/704892. |
| + // TODO(clamy): The root cause behind crbug.com/704892 is known. |
| + // Remove this code if it is never reached until ~ 2017-July-10. |
|
Charlie Reis
2017/07/07 17:12:59
Sorry for the delayed review. Might want to bump
arthursonzogni
2017/07/10 16:07:03
Done.
|
| if (navigation_handle == navigation_handle_) |
| base::debug::DumpWithoutCrashing(); |
| @@ -96,11 +96,6 @@ void CaptivePortalTabHelper::DidFinishNavigation( |
| content::NavigationHandle* navigation_handle) { |
| DCHECK_CURRENTLY_ON(content::BrowserThread::UI); |
| - // TODO(clamy): Remove this when we understand the root cause behind |
| - // crbug.com/704892. |
| - if (navigation_handle_ && !navigation_handle_->IsInMainFrame()) |
| - base::debug::DumpWithoutCrashing(); |
| - |
| // Exclude subframe navigations. |
| if (!navigation_handle->IsInMainFrame()) |
| return; |