Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 297343002: Delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown(). (Closed)

Created:
6 years, 7 months ago by horo
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown(). In current code, EmbeddedWorkerDispatcher is deleted in the destructor of RenderThreadImpl. If EmbeddedWorkerDispatcher contains any WorkerWrapper in workers_, WorkerWrapper and EmbeddedWorkerDevToolsAgent will be deleted at that time. And the destructor of EmbeddedWorkerDevToolsAgent will call RemoveEmbeddedWorkerRoute of RenderThreadImpl which is being deleted. To avoid this we should delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown(). BUG=377258, 358657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272892

Patch Set 1 #

Patch Set 2 : incorporated falken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
horo
falken@ Could you please review?
6 years, 7 months ago (2014-05-26 04:19:15 UTC) #1
falken
On 2014/05/26 04:19:15, horo wrote: > falken@ > Could you please review? lgtm. I don't ...
6 years, 7 months ago (2014-05-26 04:59:11 UTC) #2
horo
On 2014/05/26 04:59:11, falken wrote: > On 2014/05/26 04:19:15, horo wrote: > > falken@ > ...
6 years, 7 months ago (2014-05-26 05:38:53 UTC) #3
horo
jochen@ Could you please review this?
6 years, 7 months ago (2014-05-26 05:39:36 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-26 09:56:46 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-26 16:04:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/297343002/20001
6 years, 7 months ago (2014-05-26 16:07:09 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 00:03:00 UTC) #8
Message was sent while issue was closed.
Change committed as 272892

Powered by Google App Engine
This is Rietveld 408576698