Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc

Issue 2973403002: Disable CannedBrowsingDataAppCacheHelperTest.Delete on Linux/Android. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
index f6263502f08c83fc8fc7e67b461b66ccfcbadfdb..7b89c89428c81db0f600f6cbb3f68d783464bc59 100644
--- a/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
@@ -10,6 +10,7 @@
#include "base/bind_helpers.h"
#include "base/macros.h"
#include "base/stl_util.h"
+#include "build/build_config.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
@@ -123,7 +124,14 @@ TEST_F(CannedBrowsingDataAppCacheHelperTest, Empty) {
ASSERT_TRUE(helper->empty());
}
-TEST_F(CannedBrowsingDataAppCacheHelperTest, Delete) {
+// Flaky on linux. See crbug.com/740801.
+#if defined(OS_LINUX) || defined(OS_ANDROID)
+#define MAYBE_Delete DISABLED_Delete
+#else
+#define MAYBE_Delete Delete
+#endif
+
+TEST_F(CannedBrowsingDataAppCacheHelperTest, MAYBE_Delete) {
GURL manifest1("http://example.com/manifest1.xml");
GURL manifest2("http://foo.example.com/manifest2.xml");
GURL manifest3("http://bar.example.com/manifest3.xml");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698