Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2973383002: Bump meta to 1.1.0 (Closed)

Created:
3 years, 5 months ago by srawlins
Modified:
3 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : comments #

Patch Set 3 : comments #

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M pkg/meta/CHANGELOG.md View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/meta/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
srawlins
3 years, 5 months ago (2017-07-10 20:45:14 UTC) #2
nweiz
https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md File pkg/meta/CHANGELOG.md (right): https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md#newcode3 pkg/meta/CHANGELOG.md:3: (SDK issue [17999](https://github.com/dart-lang/sdk/issues/17999)). It would be good to mention ...
3 years, 5 months ago (2017-07-10 20:47:47 UTC) #3
srawlins
https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md File pkg/meta/CHANGELOG.md (right): https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md#newcode3 pkg/meta/CHANGELOG.md:3: (SDK issue [17999](https://github.com/dart-lang/sdk/issues/17999)). On 2017/07/10 20:47:46, nweiz wrote: > ...
3 years, 5 months ago (2017-07-10 21:39:13 UTC) #4
nweiz
https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md File pkg/meta/CHANGELOG.md (right): https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md#newcode7 pkg/meta/CHANGELOG.md:7: import 'package:meta/meta.dart' show alwaysThrows; On 2017/07/10 21:39:13, srawlins wrote: ...
3 years, 5 months ago (2017-07-10 21:46:41 UTC) #5
srawlins
On 2017/07/10 21:46:41, nweiz wrote: > https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md > File pkg/meta/CHANGELOG.md (right): > > https://codereview.chromium.org/2973383002/diff/1/pkg/meta/CHANGELOG.md#newcode7 > ...
3 years, 5 months ago (2017-07-10 21:48:06 UTC) #6
nweiz
lgtm
3 years, 5 months ago (2017-07-10 21:57:07 UTC) #7
srawlins
3 years, 5 months ago (2017-07-10 21:58:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c9c5767630ff40ee944e68dc792c34e7c99af02c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698