Issue 297333002: Get rid of unused API function WebViewClient:: didExecuteCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297333002: Get rid of unused API function WebViewClient:: didExecuteCommand (Closed)

Created:
6 years, 7 months ago by yosin_UTC9

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of unused API function WebViewClient:: didExecuteCommand This patch gets rid of unused API function WebViewClient::didExecuteCommand(), which is used for counting part of |document.execCommand|. We provide another counter for |document.execCommand| which counts all commands and partial counter is no longer used. This patch is chromium/content part of removing API. Blink part is done by: http://src.chromium.org/viewvc/blink?view=rev&rev=174631 BUG=376154 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273180

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	content/renderer/render_view_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	content/renderer/render_view_impl.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/297333002/1

6 years, 6 months ago (2014-05-28 01:11:30 UTC) #4

Message was sent while issue was closed.

Change committed as 273180

Expand Messages | Collapse Messages